Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nat-instance #51

Merged
merged 5 commits into from
Jun 6, 2019
Merged

Add nat-instance #51

merged 5 commits into from
Jun 6, 2019

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jun 5, 2019

what

  • Add nat-instance
  • Correctly pin terraform required_version

why

  • Allow users to choose between NAT Gateways or NAT Instances to be deployed into the public subnets to allow the servers in the private subnets to access the Internet
  • In many cases, NAT Instances are cheaper than NAT Gateways, and for some use-cases (e.g. testing/demo infrastructure) are more appropriate to use (e.g. save on cost)
  • Pin terraform required_version to 0.11.x only (the module does not support TF 0.12

references

@aknysh aknysh requested review from osterman, goruha, maximmi and Nuru June 5, 2019 16:02
@aknysh aknysh self-assigned this Jun 5, 2019
@aknysh aknysh mentioned this pull request Jun 5, 2019
Merged
Nuru
Nuru previously approved these changes Jun 5, 2019
View reviewed changes
@aknysh aknysh mentioned this pull request Jun 5, 2019
Merged
osterman
osterman requested changes Jun 5, 2019
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin AWS provider

osterman
osterman reviewed Jun 5, 2019
View reviewed changes
nat-instance.tf Outdated Show resolved Hide resolved
osterman
osterman reviewed Jun 5, 2019
View reviewed changes
nat-instance.tf Outdated Show resolved Hide resolved
@aknysh aknysh requested review from osterman and Nuru June 5, 2019 18:35
@aknysh aknysh merged commit b622cfc into master Jun 6, 2019
@aknysh aknysh deleted the add-nat-instance branch June 6, 2019 01:49
Jamie-BitFlight added a commit to bitflight-public/terraform-aws-dynamic-subnets that referenced this pull request Jun 6, 2019
@Jamie-BitFlight
Merge branch 'master' of github.com:bitflight-public/terraform-aws-dy…
b155510 
…namic-subnets into add_subnet_type_value_format

* 'master' of github.com:bitflight-public/terraform-aws-dynamic-subnets:
  Add `nat-instance` (cloudposse#51)
@GabeL7r GabeL7r mentioned this pull request Jun 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@goruha goruha Awaiting requested review from goruha

@maximmi maximmi Awaiting requested review from maximmi

@Nuru Nuru Awaiting requested review from Nuru

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknysh @osterman @Nuru