Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecs/atlantis] Update terraform-aws-dynamic-subnets version. Add the ability to choose NAT Gateways or NAT Instances #180

Merged
merged 2 commits into from
Jun 6, 2019
Merged

[ecs/atlantis] Update terraform-aws-dynamic-subnets version. Add the ability to choose NAT Gateways or NAT Instances #180

merged 2 commits into from
Jun 6, 2019

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jun 5, 2019

what

  • [ecs/atlantis] Update terraform-aws-dynamic-subnets version

why

  • Add the ability to choose NAT Gateways or NAT Instances to be deployed into public subnets to allow the servers in the private subnets to access the Internet

references

@aknysh
ecs/atlantis Update terraform-aws-dynamic-subnets version. Add th…
c4611cc 
…e ability to choose NAT Gateways or NAT Instances
@aknysh aknysh requested review from osterman, goruha, maximmi and Nuru June 5, 2019 16:51
@aknysh aknysh self-assigned this Jun 5, 2019
@aknysh aknysh mentioned this pull request Jun 5, 2019
Merged
@aknysh aknysh merged commit bb71ec9 into master Jun 6, 2019
@aknysh aknysh deleted the update-ecs-vpc-subnets branch June 6, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@goruha goruha Awaiting requested review from goruha

@maximmi maximmi Awaiting requested review from maximmi

@Nuru Nuru Awaiting requested review from Nuru

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @osterman