Create public subnets only when public_subnets_enabled is true
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
May 19, 2022
| @@ -12,7 +12,7 @@ module "public_label" { | |||
| } | |||
|
|
|||
| resource "aws_subnet" "public" { | |||
| count = local.subnet_az_count | |||
| count = local.public_enabled ? local.subnet_az_count : 0 | |||
|
/test all |
nitrocode
approved these changes
May 19, 2022
nitrocode
changed the title
public_subnets_enabled is true
|
Ah it looks like a PR was already created for this. Thank you for the contribution anyway @triThirty . |
|
Actually, on second thought, I don't see the same fix applied in the other PR. |
nitrocode
added
no-release
|
I changed to no-release since #162 is most likely going to be merged soon enough. This way we can combine the two PRs in a single release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
To check if create public subnet when set public_subnets_enabled false
why
Currently, when set set public_subnets_enabled false, module still creates public subnet, according to the logic of creating private subnet, there should be a check if public_subnets_enabled is false, not creating public subnet.
references
Slack thread: https://sweetops.slack.com/archives/CCT1E7JJY/p1652862041154429