Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public-only subnets #162

Merged
merged 3 commits into from
May 19, 2022
Merged

Fix public-only subnets #162

merged 3 commits into from
May 19, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 18, 2022 •
edited by nitrocode
Loading

what

  • Fix configuration of public subnets when private subnets are not created

why

  • Bug fix

@Nuru Nuru added the bugfix Change that restores intended behavior label May 18, 2022
@Nuru Nuru requested review from a team as code owners May 18, 2022 19:03
@Nuru Nuru requested review from r351574nc3 and milldr May 18, 2022 19:03
@Nuru
Copy link
Contributor Author

Nuru commented May 18, 2022

/test all

@Nuru Nuru requested review from aknysh, Benbentwo and mcalhoun May 18, 2022 19:08
@Nuru Nuru enabled auto-merge (squash) May 18, 2022 19:08
aknysh
aknysh reviewed May 18, 2022
View reviewed changes
nat-instance.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed May 18, 2022
View reviewed changes
nat-instance.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed May 18, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks

@nitrocode nitrocode mentioned this pull request May 19, 2022
Merged
@Nuru
Copy link
Contributor Author

Nuru commented May 19, 2022

/test all

@Nuru Nuru requested review from aknysh and nitrocode May 19, 2022 20:52
@Nuru Nuru merged commit 2d92a22 into master May 19, 2022
@Nuru Nuru deleted the ipv6-bugfix branch May 19, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

@mcalhoun mcalhoun Awaiting requested review from mcalhoun

@aknysh aknysh Awaiting requested review from aknysh

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @aknysh @Benbentwo