Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace vite module server with wmr/custom module server #115

Merged
merged 18 commits into from
Jun 25, 2021
Merged

Replace vite module server with wmr/custom module server #115

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0978452
Update source-map to beta version which fixes browser detection
calebeby Jun 16, 2021
c7ed8e4
WIP before modifications to rollup plugin container
calebeby Jun 16, 2021
fd0d8ab
Make it work
calebeby Jun 22, 2021
d9924df
Merge remote-tracking branch 'origin/main' into module-server
calebeby Jun 22, 2021
0a6b489
Update package-lock
calebeby Jun 22, 2021
286d657
Add postcss direct dep
calebeby Jun 22, 2021
0b02126
Add style-inject dep
calebeby Jun 22, 2021
c835951
Remove style-inject direct dep
calebeby Jun 22, 2021
0cc4c4a
Add test to make sure react/react-dom are working
calebeby Jun 22, 2021
0ff968e
Fix handling of module.exports = require('...') (from React)
calebeby Jun 23, 2021
807c022
eslint-disable comment
calebeby Jun 23, 2021
9afca74
Add comment about case that should never trigger
calebeby Jun 23, 2021
47f87e4
Add FS caching for npm bundles
calebeby Jun 23, 2021
1ad5ee5
Fix some things with CSS loading (I forgot to reenable the tests)
calebeby Jun 24, 2021
c266d28
Fix regression of in-browser printing of error messages
calebeby Jun 25, 2021
49babdd
Add TODO comments for commented source map code
calebeby Jun 25, 2021
ec584ba
Add comment explaining empty function
calebeby Jun 25, 2021
cbba823
Add changeset
calebeby Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
dist
node_modules
.browser-cache.json
.cache
6 changes: 0 additions & 6 deletions examples/menu/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,27 +106,21 @@ test(
'Desktop menus toggle open/closed',
withBrowser(async ({ screen, utils, page, user }) => {
await renderMenu({ utils, data });

const aboutBtn = await screen.getByRole('button', { name: /about/i });
const productsBtn = await screen.getByRole('button', { name: /products/i });

// First click: opens about menu
await user.click(aboutBtn);
await expect(await screen.getByText(aboutText)).toBeVisible();

// Second click: closes about menu
await user.click(aboutBtn);
await expect(await screen.getByText(aboutText)).not.toBeVisible();

// Open products menu
await user.click(productsBtn);
await expect(await screen.getByText(productsText)).toBeVisible();

// Clicking about button should close products menu and open about menu
await user.click(aboutBtn);
await expect(await screen.getByText(productsText)).not.toBeVisible();
await expect(await screen.getByText(aboutText)).toBeVisible();

// Click near the bottom of the screen (outside the menu), and the menu should close
await page.mouse.click(page.viewport().width / 2, page.viewport().height);
await expect(await screen.getByText(aboutText)).not.toBeVisible();
Expand Down
Loading