-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace vite module server with wmr/custom module server #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it thought it was in a browser whenever fetch existed, which made it break
calebeby
commented
Jun 22, 2021
gerardo-rodriguez
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few questions, otherwise, looks good to me. Quite the PR! 😅
Merged
This was referenced Jul 7, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing
It might be easiest to review in:
https://github1s.com/cloudfour/pleasantest/pull/115
To review the changes to
src/module-server/rollup-plugin-container.ts
, use this diff which shows the differences from WMR's version of that file.Remaining issues:
Source Maps
Since WMR does not support source maps, Pleasantest's code to fix the stack traces from in-browser errors does not work. So I commented out the source-map-dependent code in Pleasantest for now. I will follow up with a PR to add source map support.
For now, errors from runJS/runJS-imported code look like this 🤮:
I added
.skip
for the tests for this functionality, so in the follow-up PR I'll re-enable those tests.Configurability of module server
Right now the configuration is not exposed. This is a pretty easy feature to add but I figured I'd leave it for a follow-up PR since this PR is already really big, only to get the tests passing.
Proposed API: