Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine the Event Log code example #1357

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Refine the Event Log code example #1357

merged 3 commits into from
Jul 1, 2021

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Jun 30, 2021 •
edited
Loading

Overview

This PR refines the Event Log code example.

Screenshots

Screen Shot 2021-06-30 at 2 07 00 PM

Testing

Preview: https://deploy-preview-1357--cloudfour-patterns.netlify.app/?path=/docs/components-event-log--example

  1. Review the code example for accuracy

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8998a90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gerardo-rodriguez gerardo-rodriguez self-assigned this Jun 30, 2021
@gerardo-rodriguez gerardo-rodriguez requested review from tylersticka and a team June 30, 2021 21:20
tylersticka
tylersticka reviewed Jun 30, 2021
View reviewed changes
src/components/event-log/event-log.stories.mdx Outdated
{% endembed %}
{% endfor %}
{% endblock %}
{% endembed %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerardo-rodriguez This looks like it might also be a candidate for loading the template contents via raw-loader. See my comment here: #1356 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 8998a90

@gerardo-rodriguez
Merge branch 'v-next' of github.com:cloudfour/cloudfour.com-patterns …
d4cf22b 
…into chore/event-log-source-examples

* 'v-next' of github.com:cloudfour/cloudfour.com-patterns:
  Refine the Dot Leader list code example (#1356)
  Comment Form code example + docs + template updates (#1353)
  Add small size of avatar (#1358)
@gerardo-rodriguez
Use raw-loader for demo
8998a90
@gerardo-rodriguez gerardo-rodriguez merged commit d407653 into v-next Jul 1, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the chore/event-log-source-examples branch July 1, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersticka tylersticka tylersticka approved these changes

Assignees

@gerardo-rodriguez gerardo-rodriguez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerardo-rodriguez @tylersticka