Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Form code example + docs + template updates #1353

Merged
merged 7 commits into from
Jun 30, 2021
Merged

Comment Form code example + docs + template updates #1353

merged 7 commits into from
Jun 30, 2021

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Jun 29, 2021 •
edited
Loading

Overview

Refine Comment Form component code examples and docs.

I also updated the template by dropping the parenthesis on the logged_in_user object property calls, following what I did for PR 1300.

Screenshots

Screen Shot 2021-06-29 at 4 42 29 PM

Testing

Preview: https://deploy-preview-1353--cloudfour-patterns.netlify.app/?path=/docs/components-comment-form--default-story

  1. Review code examples for accuracy
  2. Review template changes

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 818dd08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gerardo-rodriguez gerardo-rodriguez changed the title Chore/comment form source examples Comment Form code example + docs + template updates Jun 29, 2021
@gerardo-rodriguez gerardo-rodriguez self-assigned this Jun 29, 2021
@gerardo-rodriguez gerardo-rodriguez marked this pull request as ready for review June 29, 2021 23:50
@gerardo-rodriguez gerardo-rodriguez requested review from tylersticka and a team June 29, 2021 23:53
@gerardo-rodriguez gerardo-rodriguez merged commit 68bfa9e into v-next Jun 30, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the chore/comment-form-source-examples branch June 30, 2021 21:54
@github-actions github-actions bot mentioned this pull request Jun 30, 2021
Merged
gerardo-rodriguez added a commit that referenced this pull request Jul 1, 2021
@gerardo-rodriguez
Merge branch 'v-next' of github.com:cloudfour/cloudfour.com-patterns …
d4cf22b 
…into chore/event-log-source-examples

* 'v-next' of github.com:cloudfour/cloudfour.com-patterns:
  Refine the Dot Leader list code example (#1356)
  Comment Form code example + docs + template updates (#1353)
  Add small size of avatar (#1358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersticka tylersticka tylersticka approved these changes

Assignees

@gerardo-rodriguez gerardo-rodriguez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerardo-rodriguez @tylersticka