Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prototype for comment threads #1230

Merged
merged 3 commits into from
May 24, 2021
Merged

Add prototype for comment threads #1230

merged 3 commits into from
May 24, 2021

Conversation

AriannaChau
Copy link
Contributor

@AriannaChau AriannaChau commented May 21, 2021 •
edited
Loading

Overview

This PR adds a prototype for comment threads.

Screenshots

Small screens:
Screen Shot 2021-05-21 at 3 19 54 PM

Large screens:
Screen Shot 2021-05-21 at 3 20 30 PM

Testing

  1. Deploy link

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 367c29d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AriannaChau AriannaChau marked this pull request as ready for review May 21, 2021 23:01
@AriannaChau AriannaChau requested a review from tylersticka May 21, 2021 23:01
tylersticka
tylersticka reviewed May 21, 2021
View reviewed changes
Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AriannaChau It looks like this needs a dark theme?

Screen Shot 2021-05-21 at 4 20 43 PM

@AriannaChau
Copy link
Contributor Author

@tylersticka

Oh my god 🤦🏻‍♀️ I completely spaced that.

@AriannaChau AriannaChau requested a review from tylersticka May 22, 2021 00:09
@dromo77 dromo77 self-requested a review May 24, 2021 16:13
dromo77
dromo77 approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@dromo77 dromo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@AriannaChau AriannaChau merged commit f37bf0c into v-next May 24, 2021
@AriannaChau AriannaChau mentioned this pull request May 24, 2021
Closed
@tylersticka tylersticka deleted the design/comment-thread branch June 29, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dromo77 dromo77 dromo77 approved these changes

@tylersticka tylersticka Awaiting requested review from tylersticka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AriannaChau @tylersticka @dromo77