Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments pattern #487

Closed
dromo77 opened this issue Feb 21, 2020 · 3 comments
Closed

Add comments pattern #487

dromo77 opened this issue Feb 21, 2020 · 3 comments
Assignees
Labels
🎨 design Requires visual, UX or UI design decisions

Comments

@dromo77
Copy link
Contributor

dromo77 commented Feb 21, 2020

Create a pattern for comments, comments can be found on article pages.

comments

@dromo77 dromo77 added the 🎨 design Requires visual, UX or UI design decisions label Feb 21, 2020
@tylersticka
Copy link
Member

These patterns are feeling kind of cramped in longer threads.

I also think we may have flipped the hierarchy the opposite of what it should be, where author/date might be more important up top. I think we were designing these as if they were tweet-length, but since then we've had some pretty long comments where it's unclear who is talking till you've finished reading.

@tylersticka tylersticka added the ✋ blocked Can't proceed quite yet label Apr 15, 2020
@tylersticka tylersticka self-assigned this Dec 15, 2020
@tylersticka tylersticka removed the ✋ blocked Can't proceed quite yet label Dec 15, 2020
@tylersticka
Copy link
Member

tylersticka commented Dec 22, 2020

The last week or two has been kind of interrupty for me, before the holiday I thought I'd share some of my progress.

Here's a chunk of the comment thread for one of our articles on our live site on a narrow screen:

Screen Shot 2020-12-22 at 15 47 59

I like how clean it is and how the threading is straightforward. I dislike that the name and info is below the comment… it nicely consolidates meta information to one line, but when comments get longer, it omits the context of who is actually speaking. I also think it ends up feeling more and more cluttered the longer the thread gets, as everything is quite condensed.

I've been experimenting with a layout more like this (same content but with random placeholder avatars):

Screen Shot 2020-12-22 at 3 46 32 PM

Things I like:

  • I think the avatars are fun and add visual interest. I could see us adding a little Cloud Four badge to team member avatars, for example.
  • Having the commenter name first improves a lot of the issues I mentioned earlier.
  • I like 💬 for reply versus ↪️, I think it feels more human.
  • I dig having more whitespace.

Thing I'm not quite satisfied with:

  • The date and reply links feel pretty floaty now. The darker "Reply" links on the right versus the muted dates cause an odd reading line. I originally had dates up near the author but moved them to accommodate longer names, but maybe they'd work better as a unified double-line element with space between that and the comment body?
  • The threads feel visually busy. The avatars, body content indentation and thread lines are suggesting a lot of unresolved whitespace chunks, at least to my eye.

Anyway! There's a progress update.

@AriannaChau
Copy link
Contributor

Here is the PR for the prototypes for this design: #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Requires visual, UX or UI design decisions
Projects
None yet
Development

No branches or pull requests

3 participants