feat: Add protocol field in route-registrar spec #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1tamara
force-pushed
the
implement-protocol-field
branch
from
2cabec5
to
56fe6d2
Compare
|
@geofffranks could you have a look at this PR, if you have time? It's the continuation of cloudfoundry/route-registrar#32. |
domdom82
approved these changes
May 17, 2023
|
LGTM - I'll merge after 0.267.0 gets shipped (should be sometime today) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change: The current route-registrar spec has no option to define protocol for registered routes. It makes impossible to register a HTTP/2 route. The change enhances route-registrar spec with protocol property in order to support publishing HTTP/2 routes
An explanation of the use cases your change solves: Related to route-registrar: support for publishing HTTP/2 routes #320
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics): Route-registrar manifest change. If route.protocol is provided, the provided value should be used. Otherwise the protocol remains empty and Gorouter uses http1 route.
Expected result after the change
Current result before the change
Links to any other associated PRs: feat: Implement protocol field route-registrar#32
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run all the unit tests using
scripts/run-unit-tests-in-docker(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
(Optional) I have run CF Acceptance Tests on bosh lite