Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route-registrar: support for publishing HTTP/2 routes #320

Closed
a18e opened this issue Apr 28, 2023 · 0 comments
Closed

route-registrar: support for publishing HTTP/2 routes #320

a18e opened this issue Apr 28, 2023 · 0 comments

Comments

@a18e
Copy link
Contributor

a18e commented Apr 28, 2023 •
edited
Loading

Is this a security vulnerability?

No

Issue

route-registrar does not support publishing HTTP/2 routes

PR

cloudfoundry/route-registrar#32

Context

pcap-release is a WIP platform service that communicates via GRPC with the client outside the landscape.
pcap-api, the central component of pcap-release is using route-registrar to publish its route to NATS.
However, GRPC requires HTTP/2 and it is currently not possible to publish a H/2 route with route-registrar.

We are more than happy to implement the feature ourselves, we just wanted to get some feedback first.

  • Is there a reason H/2 support has not been added to route-registrar yet?
  • Do you have any objections?
  • Do you agree with our assessment below?

Additional Context

gorouter routing table entry for pcap-api with our current route-registrar config:

"pcap.cf.<sysdomain>":[\{"address":"10.0.72.2:8080","protocol":"http1","tls":false,"ttl":120,"tags":null,"private_instance_id":"5213a126-915e-4a8a-7e5d-d4a500755e31"}]
@b1tamara b1tamara mentioned this issue Apr 28, 2023
Merged
maxmoehl added a commit to sap-contributions/route-registrar that referenced this issue May 4, 2023
@maxmoehl @b1tamara
feat: implement protocol field
0d865b3 
To support http2 routes, this commit adds an additional field to the
route configuration called `protocol` which can be set to `http` or
`http2` (or left empty). The field is also included in the route that is
announced to gorouter.

Co-Authored-By: Tamara Boehm <[email protected]>
Resolves: cloudfoundry/routing-release#320
b1tamara added a commit to sap-contributions/route-registrar that referenced this issue May 5, 2023
@maxmoehl @b1tamara
feat: implement protocol field
a2045db 
To support http2 routes, this commit adds an additional field to the
route configuration called `protocol` which can be set to `http` or
`http2` (or left empty). The field is also included in the route that is
announced to gorouter.

Co-Authored-By: Tamara Boehm <[email protected]>
Resolves: cloudfoundry/routing-release#320
@b1tamara b1tamara mentioned this issue May 10, 2023
Merged
5 tasks
domdom82 pushed a commit to domdom82/routing-release that referenced this issue Jul 12, 2023
@mariash
Retry in healthchecker instead of relying on monit (cloudfoundry#320)
05d25ec 
When healthchecker fails to connect to gorouter /health endpoint retry 3
times before failing. Monit will restart gorouter whenever healthchecker
fails instead of relying on monit counting how many times healthchecker
failed. Monit poll cycle is 10s and delay in healthchecker startup makes
it harder to predict how many poll cycles needed before we restart
gorouter.
@a18e a18e mentioned this issue Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@a18e