Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runc submodule #255

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Remove runc submodule #255

merged 1 commit into from
Mar 3, 2023

Conversation

winkingturtle-vmw
Copy link
Contributor

  • build runc from guardian and bump version of runc to be the same as what's running in containerd
  • Fix sync-package-specs to include missing files

When running this script, make sure gosub PR-12 is included as the minimum version

addresses: #252

- build runc from guardian and bump version of runc to be the same
as what's running in containerd
- Fix sync-package-specs to include missing files

When running this script, make sure [gosub PR-12](vito/gosub#12)
if included as the minimum version

addresses: #252
Copy link
Contributor

@ebroberson ebroberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MarcPaquette MarcPaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. We also spoke on a zoom session about these changes and they make sense.

@MarcPaquette MarcPaquette merged commit a6a8be1 into develop Mar 3, 2023
@jrussett jrussett deleted the issue-252 branch October 10, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants