containerd and runc are included in two places that cause versions falling out of sync #252
Closed
2 tasks done
Assignees
Comments
winkingturtle-vmw
added a commit
to cloudfoundry/guardian
that referenced
this issue
Feb 13, 2023
- ./bin/ctr - ./bin/containerd - ./bin/containerd-shim - ./bin/containerd-shim-runc-v1 - ./bin/containerd-shim-runc-v2 Resolves cloudfoundry/garden-runc-release#252
winkingturtle-vmw
added a commit
that referenced
this issue
Feb 14, 2023
- Remove containerd submodule Resolves #252
This was referenced Feb 14, 2023
geofffranks
pushed a commit
to cloudfoundry/guardian
that referenced
this issue
Feb 14, 2023
- ./bin/ctr - ./bin/containerd - ./bin/containerd-shim - ./bin/containerd-shim-runc-v1 - ./bin/containerd-shim-runc-v2 Resolves cloudfoundry/garden-runc-release#252
winkingturtle-vmw
added a commit
that referenced
this issue
Feb 14, 2023
- Remove containerd submodule Resolves #252
winkingturtle-vmw
added a commit
to cloudfoundry/guardian
that referenced
this issue
Mar 3, 2023
so that it can be build from within garden-runc-release addresses: cloudfoundry/garden-runc-release#252
winkingturtle-vmw
added a commit
that referenced
this issue
Mar 3, 2023
- build runc from guardian and bump version of runc to be the same as what's running in containerd - Fix sync-package-specs to include missing files When running this script, make sure [gosub PR-12](vito/gosub#12) if included as the minimum version addresses: #252
Merged
geofffranks
pushed a commit
to cloudfoundry/guardian
that referenced
this issue
Mar 3, 2023
so that it can be build from within garden-runc-release addresses: cloudfoundry/garden-runc-release#252
|
Next releases will run runc version 1.1.4 upgraded from 1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently we have two versions of containerd under this repo:
gopathguardianThis is causing an issue whenever there is a bump for the module. We would have to make sure that the submodule is also bumped so that the two versions are in sync.
This same situation is also true for
runc. As forrunc, it looks like the versions have already diverged, where submoduled version is lacking behind moduled version inguardian.Steps to reproduce
Logs
Docker image (if relevant)
Cause
Resolution
Modify
guardianso that required binaries are all checked in undervendordirectory. This would require changing packaging spec and ci helpers so that correct path of the binary is being built. With this change, we would get notified of any changes in upstream and able to patch both theguardianmodule and bosh-release to built the new version.The text was updated successfully, but these errors were encountered: