Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-652: Updated the PR template, per the request of @rkoster. #654

Merged
merged 1 commit into from
Jan 5, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,36 @@ If you are confident that you're covered under a Corporate CLA, please make sure

--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------

- [ ] Please check this box and fill the data as below once you have run the unit tests.
Code coverage should keeps at 100%.
# Checklist:

Please check each of the boxes below for which you have completed the corresponding task:

- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] All unit tests pass locally (after my changes)
- [ ] Rubocop reports zero offenses (after my changes)

Please include below the summary portions of the output from the following 2 scripts:

```
pushd src/bosh_azure_cpi
./bin/test-unit
./bin/rubocop_check
popd
```

NOTE: Please see how to setup dev environment and run unit tests in docs/development.md.
_NOTE:_ Please see how to setup dev environment and run unit tests in docs/development.md.

### Unit Test output:

> (TODO: Paste unit test script summary output here)

### Rubocop output:

> (TODO: Paste rubocop script summary output here)

### Changelog
# Changelog

*
*
Expand Down