Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-652: Updated the PR template, per the request of @rkoster. #654

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

Justin-W
Copy link
Contributor

See: #652 (comment)

Note: The new template content is similar to corresponding content within the Vsphere CPI's PR template.

Checklist:

Please check each of the boxes below for which you have completed the corresponding task:

  • I have performed a self-review of my own code
  • All unit tests pass locally (after my changes)
  • Rubocop reports zero offenses (after my changes)

Please include below the summary portions of the output from the following 2 scripts:

pushd src/bosh_azure_cpi
  ./bin/test-unit
  ./bin/rubocop_check
popd

NOTE: Please see how to setup dev environment and run unit tests in docs/development.md.

Unit Test output:

972 examples, 0 failures
Coverage report generated for RSpec to /Users/justinw/go/src/github.com/cloudfoundry/bosh-azure-cpi-release/src/bosh_azure_cpi/coverage. 4182 / 4203 LOC (99.5%) covered.

Rubocop output:

184 files inspected, no offenses detected

Changelog

See: cloudfoundry#652 (comment)

Note: The new template content is similar to corresponding content within the Vsphere CPI's PR template.
@rkoster rkoster requested review from rkoster, a team and KaiHofstetter and removed request for a team January 5, 2022 09:08
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkoster
Copy link
Contributor

rkoster commented Jan 5, 2022

Thanks! @Justin-W

@rkoster rkoster merged commit 3b8eb2a into cloudfoundry:master Jan 5, 2022
@Justin-W Justin-W deleted the issue-652 branch January 5, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants