metricsgateway ut panics because of testhelpers/websocket_handler #558

src/autoscaler/metricsgateway/helpers/ws_helper_test.go

@@ -105,6 +105,10 @@ var _ = Describe("WsHelper", func() {
 			err = wsHelper.SetupConn()
 			Expect(err).NotTo(HaveOccurred())
 
+			err = wsHelper.Ping()
+			Expect(err).ShouldNot(HaveOccurred())
+			Eventually(pingPongChan, 5*time.Second, 1*time.Second).Should(Receive(Equal(1)))
+
 		})
 		It("close the websocket connection", func() {
 			wsHelper.CloseConn()

src/autoscaler/testhelpers/websocket_handler.go

@@ -30,7 +30,10 @@ func NewWebsocketHandler(m chan []byte, pingPongChan chan int, keepAlive time.Du
 func (h *WebsocketHandler) CloseWSConnection() {
 	h.conLock.Lock()
 	defer h.conLock.Unlock()
-	h.wsConn.Close()
+	if h.wsConn != nil {
+		h.wsConn.Close()
+
+	}
 }
 func (h *WebsocketHandler) ServeWebsocket(rw http.ResponseWriter, r *http.Request) {
 	upgrader := websocket.Upgrader{