This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
metricsgateway ut panics because of testhelpers/websocket_handler #558 #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/171176260 The labels on this github issue will be updated when the story is started. |
|
LGTM |
cdlliuy
added a commit
that referenced
this pull request
Apr 15, 2020
* upgrade prometheus client_golang to v1.2.1 * Change all the sql statements and import sqlx libary (#549) * MetricsCollector: Only process HTTPStartStopEvents with peerType client (#541) * MetricsCollector: Only process HTTPStartStopEvents with peerType client ### Description: Only process `HTTPStartStop` events with `peerType` `Client`, as they contain the app instance index in the `instanceIndex` field. Check for a non-deprecated tag `peer_type` before checking deprecated tags, and accept any envelope if `peer_type` is not present in either #### Problems fixed: `HTTPStartStop` events with `peerType` `Server` would be counted against instance `0` and thus duplicate the number of requests counted by the App Autoscaler. * bug fix: Schedules can not be removed in synchronization when an application is deleted directly #553 (#554) * bug fix: Schedules can not be removed in synchronization when an application is deleted directly #553 * modify log * Revert "upgrade prometheus client_golang to v1.2.1" (#557) * Revert "Merge pull request #552 from qibobo/dev_qy_upgrade_prometheusgo" This reverts commit 12d173b, reversing changes made to bc8e77c. * Revert "upgrade prometheus client_golang to v1.2.1" This reverts commit 994eab5. * golangapiserver: Actually test detach policy endpoint (#560) * metricsgateway ut panics because of testhelpers/websocket_handler #558 (#559) * metricsgateway ut panics because of testhelpers/websocket_handler #558 * init con first * add mysql support for golang components (#555) * add mysql support for golang components * fix typo e to err * update db changelog file with mysql * fix .travis.yml and add comment to Connection function * fix integration test * fix err in integration test * remove dbms from scalingengine.db.changelog.yml * refine the helper.go and related test cases * Format code and fix appmetrics empty error * add transaction rollback Co-authored-by: qibobo <[email protected]> Co-authored-by: ying <[email protected]> Co-authored-by: Silvestre Zabala <[email protected]> Co-authored-by: qibobo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.