This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
fixing 2 CSS issues - #210 and #258 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the cell editor is set to multiple: true, set an automatic height the multi-select control so it dispalys more than just 1 line
IE10 (as part of its browser defatuls style) adds in its own padding to input boxes, which casued the content to get pushsed down
adding a new property to Backgrid.Column called `sortType`. based on
this value, clicking on the column header will do one of the following:
- "cycle": (default) cycle beween `ascending`, `descending`,
and default
- "toggle: clicking on the colum header will toggle the sorting between
`ascending` and `descending`
this only has effect if sortable = true
|
Also, have your CSS fixes been tested across browsers? |
|
ok, the fix for #262 has been pull out of this PR. |
|
@wyuenho - yup, I tested all CSS changes in IE9, IE10, Firefox, Chrome and Safari (and here are some screenshots) Issue 210Chrome on OS X 10.8 Firefox on OS X 10.8 Safari on OS X 10.8 IE9 on Windows 7 IE10 on Windows 7 Issue 258Chrome on OS X 10.8 Firefox on OS X 10.8 Safari on OS X 10.8 IE9 on Windows 7 IE10 on Windows 7 |
|
Thanks a lot @morficus !!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes were all tested in IE8, IE9, IE10 (on Windows 7), Chrome (latest), Firefox (latest) and Safari (latest) on OS X 10.8.4