-
Notifications
You must be signed in to change notification settings - Fork 324
CSS issue in IE10 in editor mode #258
Comments
If I remove Is there a reason this needs to be there? |
I forgot. It had to be there for Firefox or Chrome to render properly if I remember correctly. File me a PR if you could fix this and not break Chrome and Firefox. |
It works in latest... I don't know about older versions. Are you supporting older versions of FF and Chrome? |
Nope. Just the lastest version of FF and Chrome. |
Ok. I can do a PR for you tonight then. |
Do the cells come out right on IE8 and IE9 currently? |
They do in IE8 and IE9 mode under IE10 in the developer tools. I haven't tested the actual browsers, but the modes will usually render just like the browser would. |
Don't know what happened here but in master "height: 100%" is still there and it still breaks IE 10 and Firefox. |
The padding has been removed instead of setting height to auto and breaking chrome. |
As you can see from the screenshots below, in my tests the current master is cutting off the text on IE 10 and Firefox 24 (I did not test other versions). On IE 10 even the samples on backgridjs.com have the same problem. Anyway, removing height: 100% from the editor as suggested by @JoshClose does solve the problem in IE and FF and it doesn't seem to break Chrome and Safari. |
Both IE 10 on Win 7 and Firefox 25 on the Mac work fine. I was testing with master. Which Windows version were you using? |
With the latest CSS from master what I found is that the editor input is always 19px high on FF and IE. height: 100% doesn't seem to have any effect. Setting the editor height to the actual desired pixel height fixes the problem (37px in this example). I'm using Bootstrap 3, the grid is styled with Bootstrap and I got a hunch that that's where the problem comes from, but I couldn't pinpoint yet the exact Bootstrap style that causes this issue. I'll investigate further when time allows. |
The text is cutoff in editor mode.
The text was updated successfully, but these errors were encountered: