Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

CSS issue in IE10 in editor mode #258

Closed
JoshClose opened this issue Jun 27, 2013 · 14 comments
Closed

CSS issue in IE10 in editor mode #258

JoshClose opened this issue Jun 27, 2013 · 14 comments
Labels
Milestone

Comments

@JoshClose
Copy link

The text is cutoff in editor mode.

image

@JoshClose
Copy link
Author

If I remove height: 100%; from .backgrid td.editor input[type=text], everything works fine.

Is there a reason this needs to be there?

@wyuenho
Copy link
Contributor

wyuenho commented Jun 27, 2013

I forgot. It had to be there for Firefox or Chrome to render properly if I remember correctly. File me a PR if you could fix this and not break Chrome and Firefox.

@JoshClose
Copy link
Author

It works in latest... I don't know about older versions. Are you supporting older versions of FF and Chrome?

@wyuenho
Copy link
Contributor

wyuenho commented Jun 27, 2013

Nope. Just the lastest version of FF and Chrome.

@JoshClose
Copy link
Author

Ok. I can do a PR for you tonight then.

@wyuenho
Copy link
Contributor

wyuenho commented Jun 27, 2013

Do the cells come out right on IE8 and IE9 currently?

@JoshClose
Copy link
Author

They do in IE8 and IE9 mode under IE10 in the developer tools. I haven't tested the actual browsers, but the modes will usually render just like the browser would.

@wyuenho wyuenho closed this as completed in 571ec43 Jul 6, 2013
wyuenho added a commit that referenced this issue Jul 6, 2013
Fix #210 (cell too small for multiple selection cells) and Fix #258 (cell padding too thick on IE 10)
@dcb
Copy link

dcb commented Nov 17, 2013

Don't know what happened here but in master "height: 100%" is still there and it still breaks IE 10 and Firefox.

@wyuenho
Copy link
Contributor

wyuenho commented Nov 17, 2013

The padding has been removed instead of setting height to auto and breaking chrome.

@dcb
Copy link

dcb commented Nov 17, 2013

As you can see from the screenshots below, in my tests the current master is cutting off the text on IE 10 and Firefox 24 (I did not test other versions). On IE 10 even the samples on backgridjs.com have the same problem.
I think in my example the problem appears on Firefox as well because I have bigger padding on the table cells.

Anyway, removing height: 100% from the editor as suggested by @JoshClose does solve the problem in IE and FF and it doesn't seem to break Chrome and Safari.

backgrid-editor-height-100

@wyuenho
Copy link
Contributor

wyuenho commented Nov 18, 2013

Both IE 10 on Win 7 and Firefox 25 on the Mac work fine. I was testing with master. Which Windows version were you using?

@dcb
Copy link

dcb commented Nov 18, 2013

Ok, sorry my master build was a couple of weeks old. I've got the latest and that problem is solved, but I've got another one, although it could be related to my styling as well. Now the editor seem to be losing the vertical alignment in IE10 on Win7 and Firefox 24 on Mac. I'll investigate and report back. Thanks for the support!
screen shot 2013-11-18 at 16 15 17

@dcb
Copy link

dcb commented Nov 18, 2013

With the latest CSS from master what I found is that the editor input is always 19px high on FF and IE. height: 100% doesn't seem to have any effect. Setting the editor height to the actual desired pixel height fixes the problem (37px in this example). I'm using Bootstrap 3, the grid is styled with Bootstrap and I got a hunch that that's where the problem comes from, but I couldn't pinpoint yet the exact Bootstrap style that causes this issue. I'll investigate further when time allows.

screen shot 2013-11-18 at 22 36 13

@ntodorov
Copy link

ntodorov commented Jun 30, 2016

I see similar cutoff in Chrome Version 53.0.2783.4 dev-m (64-bit)
6-30-2016 9-30-26 am
the screenshot if from backgridjs.com - it is the latest version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants