Default local dev server to *

[jspspike]

Fixes #3732

Depends on cloudflare/miniflare#650 being merged and released

Associated docs issue(s)/PR(s):

cloudflare/cloudflare-docs#10320

Author has included the following, where applicable:

• Tests
• Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: a09a4fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6251007994/npm-package-wrangler-3733

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6251007994/npm-package-wrangler-3733

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6251007994/npm-package-wrangler-3733 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6251007994/npm-package-cloudflare-pages-shared-3733

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	3.20230918.0	3.20230918.0
workerd	1.20230904.0	1.20230904.0
workerd --version	1.20230904.0	2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Merging #3733 (a09a4fa) into main (d8833ef) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3733      +/-   ##
==========================================
+ Coverage   74.85%   74.89%   +0.04%     
==========================================
  Files         196      196              
  Lines       11604    11604              
  Branches     3044     3044              
==========================================
+ Hits         8686     8691       +5     
+ Misses       2918     2913       -5     

Files Changed	Coverage Δ
packages/wrangler/src/config/validation.ts	89.98% <100.00%> (ø)

... and 3 files with indirect coverage changes

[mrbbot]

Functionally, looks good! Tested by running curl http://127.0.0.1:8787 and curl "http://[::1]:8787". 👍 One thing I've noticed though is there's quite a bit of logging. Every time I save my worker file I see...

[mf:inf] Updated and ready on http://*:8787 
[mf:inf] - http://127.0.0.1:8787
[mf:inf] - http://[::1]:8787
[mf:inf] - http://[fe80::1]:8787
[mf:inf] - http://127.0.2.2:8787
[mf:inf] - http://127.0.2.3:8787
[mf:inf] - http://[fe80::3cbe:4bff:fe5e:6eb1]:8787
[mf:inf] - http://[fe80::3cbe:4bff:fe5e:6eb0]:8787
[mf:inf] - http://[fe80::3cbe:4bff:fe5e:6eaf]:8787
[mf:inf] - http://[fe80::bcd0:74ff:fe37:b32c]:8787
[mf:inf] - http://[fe80::14b0:1478:434f:2494]:8787
[mf:inf] - http://192.168.0.46:8787
[mf:inf] - http://[fdba:a732:28d0:4944:8f3:842d:693b:8f20]:8787
[mf:inf] - http://[fe80::9817:7bff:feb2:549e]:8787
[mf:inf] - http://[fe80::9817:7bff:feb2:549e]:8787
[mf:inf] - http://[fe80::8b7c:2b8f:179:f497]:8787
[mf:inf] - http://[fe80::d633:1bf6:5607:ca25]:8787
[mf:inf] - http://[fe80::ce81:b1c:bd2c:69e]:8787
[mf:inf] - http://[fe80::3a5a:bc92:12a2:9a5b]:8787
[mf:inf] - http://[fe80::1cde:4059:8ab4:1d1e]:8787
[mf:inf] - http://192.168.0.163:8787
[mf:inf] - http://[fdba:a732:28d0:4944:1880:5946:afb2:2454]:8787

This is definitely accurate, but maybe we don't want to log all addresses every time. I'm not sure whether this should be changed in Miniflare or just Wrangler. If just Wrangler, we could do something sneaky in WranglerLog:

workers-sdk/packages/wrangler/src/dev/miniflare.ts

Line 118 in a986f19

info(message: string) {

Maybe hide all info() logs starting with - after seeing a message starting with Updated and ready ? Or we could filter out the IPv6 addresses from the logs? AFAIK, most other JavaScript dev server CLIs don't include them.

[jspspike]

Waiting on cloudflare/miniflare#686 to be merged to address above comment

[JacobMGEvans]

cloudflare/miniflare#686 has been merged.

[jspspike]

@JacobMGEvans I should have mentioned released and then miniflare version updated in wrangler. Which should happen soon!

[irvinebroque]

For when we revisit — sounds like we would really benefit from some kind of remote dev integration / smoke test?

[mrbbot]

We should already have a basic one here...

workers-sdk/packages/wrangler/e2e/dev.test.ts

Lines 120 to 153 in 78e9397

	it("can modify worker during dev session (remote)", async () => {
	await runDevSession(workerPath, "--remote --ip 127.0.0.1", async (port) => {
	const { text } = await retry(
	(s) => s.status !== 200 || s.text === "",
	async () => {
	const r = await fetch(`http://127.0.0.1:${port}`);
	return { text: await r.text(), status: r.status };
	}
	);
	expect(text).toMatchInlineSnapshot('"Hello World!"');
	await seed(workerPath, {
	"src/index.ts": dedent`
	export default {
	fetch(request) {
	return new Response("Updated Worker!")
	}
	}`,
	});
	// Give a bit of time for the change to propagate.
	// Otherwise the process has a tendency to hang.
	await setTimeout(5000);
	const { text: text2 } = await retry(
	(s) => s.status !== 200 || s.text === "Hello World!",
	async () => {
	const r = await fetch(`http://127.0.0.1:${port}`);
	return { text: await r.text(), status: r.status };
	}
	);
	expect(text2).toMatchInlineSnapshot('"Updated Worker!"');
	});
	});

Not sure why that didn't catch this 😕