-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ipv6 host #650
Conversation
|
ad054bd
to
39fd910
Compare
fd6654c
to
04ea804
Compare
localhost
instead of 127.0.0.1
04ea804
to
ad1f005
Compare
Small change but do you think we should maybe change this to host or something else? Just to let the user know that it's listening on more than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change this to host or something else?
Hmmm, we could do. The reason it's accessible host is so that when IDE's autolink it in integrated terminals, it goes straight to the browser. Miniflare 2 solved this by logging the listening host first, then all IPs this was accessible on:
miniflare/packages/http-server/src/index.ts
Lines 481 to 484 in 7e4d906
log.info(`Listening on ${host ?? ""}:${usedPort}`); | |
for (const accessibleHost of accessibleHosts) { | |
log.info(`- ${protocol}://${accessibleHost}:${usedPort}`); | |
} |
Maybe we should do something like that?
ad1f005
to
e5da00b
Compare
e5da00b
to
3a7ca1e
Compare
3330ce1
to
f37aad7
Compare
23351bf
to
70394c7
Compare
70394c7
to
d61b3f7
Compare
Allows
host
to be ipv6 and defaults tolocalhost
foraccessibleHost