Upgrade to V8 11.7 #1184
Merged
Upgrade to V8 11.7 #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 14, 2023
ohodson
added a commit
that referenced
this pull request
Oct 6, 2023
clang-cl has a different syntax for specifying the C++ standard version so was rejecting the fix added in #1184 for the DCHECK in V8's graph-visualizer.cc that needs C++20. V8 DCHECKs are enabled for dbg builds. This is fixed in .bazelrc. To add to my own confusion when looking into this issue, the junction we create in the workspace folder, `external`, was stable. The junction is created to make it easy to find sources to downloaded dependencies and also to help VSCode find the right sources when bazel build emits compilation errors. Unfortunately, the junction was stale locally so following the error links reported in VSCode went to an old version of V8 on the disk with entirely different code that could not possibly have caused the error observed. As a result, the script that creates the junction when VSCode opens the project is updated to delete any existing `external` junction and create it anew.
ohodson
added a commit
that referenced
this pull request
Oct 6, 2023
clang-cl has a different syntax for specifying the C++ standard version so was rejecting the fix added in #1184 for the DCHECK in V8's graph-visualizer.cc that needs C++20. V8 DCHECKs are enabled for dbg builds. This is fixed in .bazelrc. To add to my own confusion when looking into this issue, the junction we create in the workspace folder, `external`, was stable. The junction is created to make it easy to find sources to downloaded dependencies and also to help VSCode find the right sources when bazel build emits compilation errors. Unfortunately, the junction was stale locally so following the error links reported in VSCode went to an old version of V8 on the disk with entirely different code that could not possibly have caused the error observed. As a result, the script that creates the junction when VSCode opens the project is updated to delete any existing `external` junction and create it anew.
ohodson
added a commit
that referenced
this pull request
Oct 6, 2023
clang-cl has a different syntax for specifying the C++ standard version so was rejecting the fix added in #1184 for the DCHECK in V8's graph-visualizer.cc that needs C++20. V8 DCHECKs are enabled for dbg builds. This is fixed in .bazelrc. To add to my own confusion when looking into this issue, the junction we create in the workspace folder, `external`, was stable. The junction is created to make it easy to find sources to downloaded dependencies and also to help VSCode find the right sources when bazel build emits compilation errors. Unfortunately, the junction was stale locally so following the error links reported in VSCode went to an old version of V8 on the disk with entirely different code that could not possibly have caused the error observed. As a result, the script that creates the junction when VSCode opens the project is updated to delete any existing `external` junction and create it anew.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This V8 update is fairly inconspicuous, the new version is 11.7.439.17. Notable changes:
0009-Speed-up-V8-bazel-build-by-always-using-target-cfg.patchgot cleaned up as the change that avoids running the torque generator twice has been upstreamed. This makes the patch much smaller.//external:absl_optionaldependency in bazel build, it is not actually being used and would require wider build system changes.