Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
clang-cl has a different syntax for specifying the C++ standard version so was rejecting the fix added in #1184 for the DCHECK in V8's graph-visualizer.cc that needs C++20. V8 DCHECKs are enabled for dbg builds. This is fixed in .bazelrc. To add to my own confusion when looking into this issue, the junction we create in the workspace folder, `external`, was stable. The junction is created to make it easy to find sources to downloaded dependencies and also to help VSCode find the right sources when bazel build emits compilation errors. Unfortunately, the junction was stale locally so following the error links reported in VSCode went to an old version of V8 on the disk with entirely different code that could not possibly have caused the error observed. As a result, the script that creates the junction when VSCode opens the project is updated to delete any existing `external` junction and create it anew.
- Loading branch information