Updated version.clj #395
Merged
Updated version.clj #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project was on version 1.0.0 before update to 2.0.0. It only uses one function from version-clj in refactor-nrepl.artifacts/artifact-versions: version-sort. This is the change that went into that function from version 1.0.0 to 2.0.0: xsc/version-clj@v1.0.0...v2.0.0#diff-c6b8870bce46e7fe981de278c5a5eb53847fd489211487800632111290202b63R56 No change to the actual function, but that function uses version-compare function, which did have a change, see: xsc/version-clj@v1.0.0...v2.0.0#diff-c6b8870bce46e7fe981de278c5a5eb53847fd489211487800632111290202b63R23 If you look at this commit: xsc/version-clj@c05eeb8 you'll see that the tests for version-sort & version-compare were added for the release 1.0.0 and were not amended at the latest release 2.0.2. And finally a pedantic comparison of version 1.0.0 & the current stable release 2.0.2 (which is this commit's update): xsc/version-clj@v1.0.0...v2.0.2
|
Running As well as 7/13 CI jobs. Can you please re-run the tests on all the CI profiles, to ensure that it's not just a glitch? Thanks |
vemv
approved these changes
Jul 11, 2023
|
Cheers 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] You've added tests (if possible) to cover your change(s)lein do clean, test)./build.sh install-- takes a long time)- [ ] You've updated the changelog (if adding/changing user-visible functionality)- [ ] You've updated the readme (if adding/changing user-visible functionality)This is in response to: #393 (comment)
and this comment in particular:
I guess not everybody uses CHANGELOGs...
The project,
version-clj, was on version 1.0.0 before update to 2.0.0.It only uses one function from version-clj in
refactor-nrepl.artifacts/artifact-versions: version-sort:
refactor-nrepl/src/refactor_nrepl/artifacts.clj
Line 8 in beaa226
refactor-nrepl/src/refactor_nrepl/artifacts.clj
Line 157 in beaa226
This is the change that went into that function from version 1.0.0 to 2.0.0:
xsc/version-clj@v1.0.0...v2.0.0#diff-c6b8870bce46e7fe981de278c5a5eb53847fd489211487800632111290202b63R56
No change to the actual function, but that function uses version-compare function, which did have a change, see:
xsc/version-clj@v1.0.0...v2.0.0#diff-c6b8870bce46e7fe981de278c5a5eb53847fd489211487800632111290202b63R23
If you look at this commit:
xsc/version-clj@c05eeb8 you'll see that the tests for version-sort & version-compare were added for the release 1.0.0 and were not amended at the latest release 2.0.2.
And finally a pedantic comparison of version 1.0.0 & the current stable release 2.0.2 (which is this commit's update):
xsc/version-clj@v1.0.0...v2.0.2