Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #393

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Update deps #393

merged 2 commits into from
Jul 10, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Jul 10, 2023

Older Clojures have been removed from the matrix because core.async has a hard dependency on Clojure 1.10.

Which would complicate the test suite, which isn't worthwhile by now (Clojure 1.9 is old by now)

tools.namespace will be updated in a separate PR, because it causes a test failure which meaning I'm unsure of:

FAIL in (returns-list-of-affected-files) (form-init10896006543821848711.clj:33)
("/home/circleci/repo/testproject/src/com/move/dependent_ns2.clj" "/home/circleci/repo/testproject/src/com/move/dependent_ns1.clj" "/home/circleci/repo/testproject/src/com/move/dependent_ns1_cljs.cljs" "/home/circleci/repo/testproject/src/com/move/subdir/dependent_ns_3.clj" "/home/circleci/repo/testproject/src/com/move/subdir/dependent_ns_3_cljs.cljs" "/home/circleci/repo/testproject/src/com/move/moved_ns.clj")
expected: (= 4 (count res))
  actual: (not (= 4 6))

@dotemacs
Copy link
Contributor

$ lein ancient
[http-kit "2.7.0"] is available but we use "2.5.0"
[org.clojure/tools.namespace "1.4.4"] is available but we use "1.1.0"
[version-clj "2.0.2"] is available but we use "1.0.0"
[org.clojure/clojure "1.11.1"] is available but we use "1.10.3" (use :check-clojure to upgrade)
[clj-kondo "2023.05.26"] is available but we use "2022.06.22"

org.clojure/tools.namespace can be ignored, as per comment above.
As well as org.clojure/clojure, but the others can be updated.

project.clj Outdated
^:inline-dep [rewrite-clj "1.0.699-alpha"]
^:inline-dep [cider/orchard "0.12.0"]
^:inline-dep [cljfmt "0.9.2" :exclusions [rewrite-clj rewrite-cljs]]
^:inline-dep [clj-commons/fs"1.6.310"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests run fine and dependency is handled correctly, but maybe since the PR is still open, add a space between the clj-commons/fs & "1.6.310"?

@vemv
Copy link
Member Author

vemv commented Jul 10, 2023

Thanks!

Bumped http-kit.

version-clj makes me nervous as it went 1.x -> 2.x with no changelog.

IIRC bumping clj-kondo would introduce a linter fault with no easy fix.

@vemv
Copy link
Member Author

vemv commented Jul 10, 2023

mranderson doesn't like the new http-kit so I reverted that change.

@vemv vemv merged commit 90e9858 into master Jul 10, 2023
@vemv vemv deleted the update-deps branch July 10, 2023 15:01
@dotemacs dotemacs mentioned this pull request Jul 11, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants