-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor clj-kondo's namespace local configuration #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks on a great path to me - thanks for this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple final suggestions. Thanks for the quick iteration!
Well, looks like that's it. Unless you have any other comments, of course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there! one last round and I'll be merging.
All done. Also, I had to use double quote in tests because somehow with single quote it doesn't get the same form as when it's loaded by Also, I took this snippet from clj-kondo's code, so it should work (I guess such a small portion of code won't cause any licensing issues?) |
Thanks!
It's good. That happens simply because: user=> (= '{1 1} {1 1})
true
Yes, it's really small |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking perfect. One last q.
97cdbb3
to
0e18dcb
Compare
Thanks yet again! Will be cutting a release this evening. Cheers - V |
I have released refactor-nrepl 3.6.0 clj-refactor.el 3.6.0 is been pushed and will be available in a couple hours! |
This PR makes refactor-nrepl honor clj-kondo's namespace-local configuration of
:unused-namespace
linter via config.edn file and also via ns meta when performingclean-ns
task. I'll fix/add tests if code is finelein do clean, test
)./build.sh install
-- takes a long time)Thanks!