Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor namespace local configuration of clj-kondo #387

Closed
OknoLombarda opened this issue Sep 19, 2022 · 4 comments
Closed

Honor namespace local configuration of clj-kondo #387

OknoLombarda opened this issue Sep 19, 2022 · 4 comments

Comments

@OknoLombarda
Copy link
Contributor

refactor-nrepl already honors clj-kondo's global config for unused namespaces, but maybe it would be right to also check namespace local configuration?
@vemv
Copy link
Member

vemv commented Sep 19, 2022

I'd be fine with this, thanks for the proposal!

@vemv
Copy link
Member

vemv commented Oct 11, 2022

@OknoLombarda: did you have in mind to offer a PR?

@OknoLombarda
Copy link
Contributor Author

Yeah, I just don't have much time lately. I'll try to do it on this weekend. Also, clj-kondo supports namespace local configuration via namespace metadata, but that's probably gonna be too much? I guess I'll just add :config-in-ns support, at least for now

@vemv
Copy link
Member

vemv commented Oct 12, 2022

Sweet!

Both are nice, but any contribution is welcome!

@OknoLombarda OknoLombarda mentioned this issue Oct 15, 2022
Merged
6 tasks
OknoLombarda pushed a commit to OknoLombarda/refactor-nrepl that referenced this issue Oct 16, 2022
Mention issue clojure-emacs#387 in changelog
e4879c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vemv @OknoLombarda