Add refactor-nrepl.find-symbol-test

[vemv]

Tries reproducing https://github.com/clojure-emacs/clj-refactor.el/issues/485

find-symbol seemed to lack test coverage anyway.

[expez]

find-symbol seemed to lack test coverage anyway.

We have a lot of various integration tests for this op in the refactor-nrepl.integration-tests ns. That ns runs through the entire middleware, by sending messages like clj-refactor would and complements the more targeted unit tests.

[vemv]

Right, I was grepping for find-symbol instead of find-usages. Thanks!

I'll see if I can repro https://github.com/clojure-emacs/clj-refactor.el/issues/485 by also hacking refactor-nrepl.integration-tests.

[vemv]

The second commit managed to break the build in a pretty wild way, which is both good and bad news 🙃

[vemv]

After a few tweaks, the build is green again.

Finally, (set! *warn-on-reflection* true) wasn't causing a test failure whatsoever. It was other stuff failing.

Then how comes https://github.com/clojure-emacs/refactor-nrepl master is green?

I believe it's because of the with_cache CI step. Why are we caching repo again?

refactor-nrepl/.circleci/config.yml

Line 85 in 392d417

- repo

Seems really an odd thing to do. It plausibly is caching mranderson's work i.e. the target dir, so test results can get tainted.

[bbatsov]

Yeah, caching the repo seems pretty weird.

[vemv]

PR ready again, and green

The summary is:

• Add refactor-nrepl.find-symbol-test
  • Tries reproducing https://github.com/clojure-emacs/clj-refactor.el/issues/485
  • I did not accomplish reproducing any problem. Still it seems useful to have this increased test coverage.
• Add a testing
  • The related deftest was failing too opaquely (when failing)
• Fix set-refresh-dirs
  • Fixes an issue masked by a prior problem in CI.
• Make read-ns-form handle invalid files
  • Fixes an issue masked by a prior probem in CI.
• Remove repo caching
  • This appears to cache mranderson's work, which is plausibly problematic across CI jobs.

[bbatsov]

LGTM