Skip to content

Commit

Permalink
Address remaining reflection warnings (#324)
Browse files Browse the repository at this point in the history
  • Loading branch information
vemv authored Jul 18, 2021
1 parent cd42887 commit 392d417
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 2 additions & 3 deletions project.clj
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@

:lein-plugin {:source-paths ["lein-plugin"]}
:test {:dependencies [[print-foo "1.0.2"]]}
:dev {:global-vars {*warn-on-reflection* true}
:dependencies [[org.clojure/clojurescript "1.10.520"]
:dev {:dependencies [[org.clojure/clojurescript "1.10.520"]
[org.clojure/core.async "1.3.618" :exclusions [org.clojure/clojure org.clojure/tools.reader]]
[cider/piggieback "0.5.2"]
[commons-io/commons-io "2.8.0"]]
Expand All @@ -67,7 +66,7 @@
with-debug-bindings [[:inner 0]]
merge-meta [[:inner 0]]
try-if-let [[:block 1]]}}}]
:eastwood {:plugins [[jonase/eastwood "0.7.1"]]
:eastwood {:plugins [[jonase/eastwood "0.9.1"]]
:eastwood {;; vendored - shouldn't be tweaked for satisfying linters:
:exclude-namespaces [refactor-nrepl.ns.slam.hound.regrow]
;; :implicit-dependencies would fail spuriously when the CI matrix runs for Clojure < 1.10,
Expand Down
6 changes: 4 additions & 2 deletions test/refactor_nrepl/ns/resolve_missing_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@

(defn session-fixture
[f]
(with-open [server (server/start-server :bind "localhost" :handler *handler*)
(with-open [^nrepl.server.Server
server (server/start-server :bind "localhost" :handler *handler*)
^nrepl.transport.FnTransport
transport (nrepl/connect :port (:port server))]
(let [client (nrepl/client transport Long/MAX_VALUE)]
(binding [*session* (nrepl/client-session client)]
Expand Down Expand Up @@ -77,7 +79,7 @@
(t/is (= 'cljs.repl name))
(t/is (= :ns type)))
(t/testing "Finds macros"
(let [{:keys [error] :as response} (message {:op :resolve-missing :symbol 'dir})
(let [{:keys [^String error] :as response} (message {:op :resolve-missing :symbol 'dir})
{:keys [name type]} (first (edn/read-string (:candidates response)))]
(when error
(throw (RuntimeException. error)))
Expand Down

0 comments on commit 392d417

Please sign in to comment.