Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eval commands to single C-c C-v keymap #1805

Merged
merged 1 commit into from
Jul 16, 2016

Conversation

dpsutton
Copy link
Contributor

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s) (not applicable)
  • All tests are passing (make test) tests are not passing (none at all, actually, unrelated error)
  • The new code is not generating bytecode or M-x checkdoc warnings (preexisting ones)
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality) no changes necessary
  • You've updated the refcard (if you made changes to the commands listed there) no changes necessary

Thanks!

#1783

Actually no tests are passing right
In toplevel form:
cider-test.el:31:1:Error: Cannot open load file: No such file or directory, clojure-mode
Compiling /home/dan/projects/cider/cider-util.el...

In toplevel form:
cider-util.el:36:1:Error: Cannot open load file: No such file or directory, clojure-mode
Compiling /home/dan/projects/cider/cider.el...

In toplevel form:
cider.el:80:1:Error: Cannot open load file: No such file or directory, spinner
Compiling /home/dan/projects/cider/nrepl-client.el...

In toplevel form:
nrepl-client.el:75:1:Error: Cannot open load file: No such file or directory, queue
Compiling /home/dan/projects/cider/nrepl-dict.el...
cask exec buttercup -L .
cask exec: error: [Errno 2] No such file or directory
Makefile:41: recipe for target 'test' failed

Not sure what is causing this error but all or most tests are erroring on not finding queue, spinner, clojure-mode, etc.

@Malabarba
Copy link
Member

LGTM. 👍

@@ -22,6 +22,7 @@
* [#1736](https://github.com/clojure-emacs/cider/issues/1736): Show "See Also" links for functions/variables in documentation buffers.
* [#1767](https://github.com/clojure-emacs/cider/issues/1767): Add a command `cider-read-and-eval-defun-at-point` to insert the defun at point into the minibuffer for evaluation (bound to `C-c C-v .`).
* [#1646](https://github.com/clojure-emacs/cider/issues/1646): Add an option `cider-apropos-actions` to control the list of actions to be applied on the symbol found by an apropos search.
* [1783](https://github.com/clojure-emacs/cider/issues/1783): Put eval commands onto single map bound to `C-c C-v`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move eval commands to single C-c C-v keymap
@dpsutton
Copy link
Contributor Author

Fixed changelog note from @bbatsov and squashed commits

@bbatsov bbatsov merged commit 20ac45c into clojure-emacs:master Jul 16, 2016
@dpsutton dpsutton deleted the feature/eval_map branch October 26, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants