Make cider-eval-map and bind it to C-c C-e instead of C-c C-v

[vspinu]

Two related issues.

First, would be good to place C-c C-v eval commands into a specialized map.

Secondly, have you considered using C-c C-e for that map? cider-eval-last-sexp is already bound on C-x C-e, so using C-c C-e seems like a waste of a good key. C-c C-v is very handy and could be dedicated to something more useful than redundant eval commands.

[Malabarba]

First, would be good to place C-c C-v eval commands into a specialized map.

Do you mean actually write a separate keymap for eval commands? We could do that, there's no harm in it, but there isn't much benefit either.

However, I don't see a reason to bind it to some other key. I know a lot of people use C-c C-e, so I'd rather keep the redundancy in this case.

[vspinu]

but there isn't much benefit either.

The benefit is that people can move the whole map around to their favorite key. C-c C-v is too good to be wasted for those rarely used keys.

I know a lot of people use C-c C-e,

It might be too late to change it indeed. My personal opinion is that enforcing a consistent C-x C-e across emacs modes is worth the pain of breaking the backward compatibility.

[bbatsov]

I'd say it's too late for C-c C-e, but eventually we might have all eval commands under C-c C-v for convenience's sake.

[Malabarba]

but there isn't much benefit either.

The benefit is that people can move the whole map around to their favorite key.

PRs welcome. :-)

[bbatsov]

Like @Malabarba said. :-)

[bbatsov]

Fixed in #1805. What remains to be done is to stuff all other eval commands there as well for consistency.