Refine unit tests #512
Merged
Refine unit tests #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test:bb and test:jvm bb tasks replace the test task. I think this makes bb and jvm platform tests easier to discover. Extracted out test matrix generation to its own test-matrix bb task (was formerly invoked via a test task cmd line arg). Now employing babashka cli for test tasks. Using for both test:jvm and test:bb. Can now choose to run individual tests vars and namespaces. Our test tasks now accept --nses --patterns and --vars options which we pass thru to the cognitect test runner. Updates to babashka allow us to now no longer rely on babashka: - namespace fork (was need for test runner) - babashka spec.alpha fork (ide feature relies on spec.alpha). Closes clj-commons#507 For consitency: - dev task renamed to dev:jvm - dev-bb task renamed dev:bb. Adjusted this one to match test:bb re classpath construction. When I sent in my own --classpath I think Clojure's spec.alpha was getting in the way. Now explicitly relying on slingshot. Closes clj-commons#511 Docker run task corrected to accept args. User and dev guides updated accordingly. Closes clj-commons#506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test:bb and test:jvm bb tasks replace the test task. I think this makes bb and jvm platform tests easier to discover.
Extracted out test matrix generation to its own test-matrix bb task (was formerly invoked via a test task cmd line arg).
Now employing babashka cli for test tasks.
Using for both test:jvm and test:bb.
Can now choose to run individual tests vars and namespaces. Our test tasks now accept --nses --patterns and --vars options which we pass thru to the cognitect test runner.
Updates to babashka allow us to now no longer rely on babashka:
For consitency:
Now explicitly relying on slingshot. Closes #511
Docker run task corrected to accept args.
User and dev guides updated accordingly.
Closes #506
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.