Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test if ide api can use new built in spec.alpha in bb #507

Closed
lread opened this issue Nov 30, 2022 · 1 comment · Fixed by #512
Closed

test if ide api can use new built in spec.alpha in bb #507

lread opened this issue Nov 30, 2022 · 1 comment · Fixed by #512

Comments

@lread
Copy link
Collaborator

lread commented Nov 30, 2022

Currently

For babashka use, our docs advise folks who want to use the ide api to include a dep to a fork of spec.alpha

But...

Babashka now includes some spec.alpha support without requiring that dep

So...

I'll try that out and update Etaoin docs and tests accordingly

@lread
Copy link
Collaborator Author

lread commented Dec 1, 2022

Yup, seems like we don't need the spec.alpha fork anymore!

lread added a commit to lread/etaoin that referenced this issue Dec 2, 2022
The new test:bb and test:jvm bb tasks replace the test task.
I think this makes bb and jvm platform tests easier to discover.

Extracted out test matrix generation to its own test-matrix bb task
(was formerly invoked via a test task cmd line arg).

Now employing babashka cli for test tasks.
Using for both test:jvm and test:bb.

Can now choose to run individual tests vars and namespaces.
Our test tasks now accept --nses --patterns and --vars options which
we pass thru to the cognitect test runner.

Updates to babashka allow us to now no longer rely on babashka:
- namespace fork (was need for test runner)
- babashka spec.alpha fork (ide feature relies on spec.alpha). Closes clj-commons#507

For consitency:
- dev task renamed to dev:jvm
- dev-bb task renamed dev:bb. Adjusted this one to match test:bb re
classpath construction. When I sent in my own --classpath I think
Clojure's spec.alpha was getting in the way.

Now explicitly relying on slingshot. Closes clj-commons#511

Docker run task corrected to accept args.

User and dev guides updated accordingly.

Closes clj-commons#506
@lread lread mentioned this issue Dec 2, 2022
4 tasks
@lread lread closed this as completed in #512 Dec 2, 2022
lread added a commit that referenced this issue Dec 2, 2022
The new test:bb and test:jvm bb tasks replace the test task.
I think this makes bb and jvm platform tests easier to discover.

Extracted out test matrix generation to its own test-matrix bb task
(was formerly invoked via a test task cmd line arg).

Now employing babashka cli for test tasks.
Using for both test:jvm and test:bb.

Can now choose to run individual tests vars and namespaces.
Our test tasks now accept --nses --patterns and --vars options which
we pass thru to the cognitect test runner.

Updates to babashka allow us to now no longer rely on babashka:
- namespace fork (was need for test runner)
- babashka spec.alpha fork (ide feature relies on spec.alpha). 
Closes #507

For consitency:
- dev task renamed to dev:jvm
- dev-bb task renamed dev:bb. Adjusted this one to match test:bb re
classpath construction. When I sent in my own --classpath I think
Clojure's spec.alpha was getting in the way.

Now explicitly relying on slingshot. Closes #511

Docker run task corrected to accept args.

User and dev guides updated accordingly.

Closes #506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant