Fix API tests for geckodriver 0.23 & ChromeDriver 2.41 #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the broken browser API tests for recent versions of Firefox, Geckodriver, Chrome & ChromeDriver.
This PR partially addresses issue #162.
Versions
My test system used the following dependency versions:
OS: macOS Mojave.
I have not yet been able run the tests for the
:phantomjs
and:safari
drivers, so I would expect those to fail - however, I hope this PR gets you closer to getting the full test suite green.Removal of Firefox set-cookie test
Firefox (via Marionette) no longer allows cookies to be set against a domain using the
file:///
protocol. It only allows setting cookies against a network scheme. The test will fail with aDocument is cookie-averse
exception from Marionette.Change to delete-session
Please note that I have also made a change that allows for
delete-session
to be called against an already deleted session.I made this change because the API test fixture uses
with-driver
which callsquit
when a test has completed.quit
also callsdelete-session
behind the scenes. This caused an exception in theclose-window
test, which also callsdelete-session
.This change is perhaps debatable and I could make another PR without this change if it is not desirable, but we would then need to come up with an alternative approach to fixing the failing
test-close-window
test, which this change addresses.