Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests. #162

Closed
alehatsman opened this issue Jul 30, 2018 · 7 comments
Closed

Fix failing tests. #162

alehatsman opened this issue Jul 30, 2018 · 7 comments
Assignees
@Uunnamed

Comments

@alehatsman
Copy link
Contributor

https://circleci.com/gh/marco-m/etaoin/36
@marco-m
Copy link
Contributor

marco-m commented Aug 7, 2018

Now it is https://circleci.com/gh/igrishaev/etaoin, yes! :-)

Was your PR that removed the crash in the fixture in the firefox tests ? Now both Firefox and non-Firefox tests run to completion.

@alehatsman
Copy link
Contributor Author

@marco-m i am not sure. Will it automatically test PRs now ?

@igrishaev
Copy link
Collaborator

@atsman it should build. Let me know if it not.

@marco-m
Copy link
Contributor

marco-m commented Aug 7, 2018

If @igrishaev enabled building of PRs, yes. Unfortunately wether a project has this feature enabled or not is visible only to the project owner. We will know on the first PR :-)

If you look at my new PR #169, situation is unclear. My interpretation is the following: CircleCI detected that my own fork has CI enabled, so it used that to validate the PR. Still it is not clear if upstream has build PR enabled or not.

@marco-m
Copy link
Contributor

marco-m commented Aug 7, 2018

Yes it is setup correctly, see screenshot in #164

@scottlowe scottlowe mentioned this issue Oct 18, 2018
Merged
CodeFarmer added a commit to CodeFarmer/etaoin that referenced this issue Jul 26, 2019
@CodeFarmer
Issue clj-commons#162 - exception in fixture code is causing other te…
a542df2 
…st failures to be hidden. Problem occurs when delete-session is called by with-driver after the session is already gone (in this case, close-window).
igrishaev pushed a commit that referenced this issue Oct 31, 2019
@CodeFarmer @igrishaev
Issue #162 - exception in fixture code is causing other test failures…
fc33e11 
… to be hidden. Problem occurs when delete-session is called by with-driver after the session is already gone (in this case, close-window). (#214)
@igrishaev
Copy link
Collaborator

@Uunnamed I believe this one can be closes as our tests are green now?

@Uunnamed
Copy link
Contributor

@igrishaev yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uunnamed Uunnamed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@igrishaev @marco-m @alehatsman @Uunnamed