Skip to content

Commit

Permalink
Rename etaoin.keys/num-. to etaoin.keys/num-dot +
Browse files Browse the repository at this point in the history
The symbol `num-.` is technically an invalid Clojure symbol and can
confuse tooling.

Minor breaking change, see changelog for impact.

Closes #412
  • Loading branch information
lread committed May 15, 2022
1 parent 289a591 commit 05ef646
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 5 deletions.
16 changes: 14 additions & 2 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
= Changelog

A release with an intentional breaking changes is marked with [breaking]
A release with an intentional breaking changes is marked with:

== Unreleased
* [breaking] you probably need to change your code
* [minor breaking] you likely don't need to change your code
== Unreleased [minor breaking]

Minor Breaking Changes

* https://github.com/clj-commons/etaoin/issues/412[#412]: Rename `etaoin.keys/num-.` to `etaoin.keys/num-dot` +
The symbol `num-.` is technically an invalid Clojure symbol and can confuse tooling. +
A grep.app for `num-.` found Etaoin itself as the only user of this var.
If your code uses `etaoin.keys/num-.`, you'll need to rename it to `etaoin.keys/num-dot`.

Other Changes

* https://github.com/clj-commons/etaoin/issues/383[#383]: Drop testing for Safari on Windows, Apple no longer releases Safari for Windows
* https://github.com/clj-commons/etaoin/issues/388[#388]: Drop testing for PhantomJS, development has long ago stopped for PhantomJS
Expand Down
4 changes: 2 additions & 2 deletions src/etaoin/ide/api.clj
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"COMMAND" k/command
"CONTROL" k/control-left
"CTRL" k/control-left
"DECIMAL" #_{:clj-kondo/ignore [:unresolved-var]} k/num-.
"DECIMAL" k/num-dot
"DELETE" k/delete
"DIVIDE" k/num-slash
"DOWN" k/arrow-down
Expand Down Expand Up @@ -93,7 +93,7 @@
"NUMPAD7" k/num-7
"NUMPAD8" k/num-9
"NUMPAD9" k/num-9
"NUM_PERIOD" #_{:clj-kondo/ignore [:unresolved-var]} k/num-.
"NUM_PERIOD" k/num-dot
"NUM_PLUS" k/num-+
"NUM_DIVISION" k/num-slash
"NUM_MULTIPLY" k/num-*
Expand Down
2 changes: 1 addition & 1 deletion src/etaoin/keys.clj
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
(def num-+ \uE025)
(def num-comma \uE026)
(def num-- \uE027)
(def num-. \uE028)
(def num-dot \uE028)
(def num-slash \uE029)
(def f1 \uE031)
(def f2 \uE032)
Expand Down

0 comments on commit 05ef646

Please sign in to comment.