Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently using technically invalid symbol name: num-. #412

Closed
lread opened this issue May 15, 2022 · 0 comments · Fixed by #414
Closed

Currently using technically invalid symbol name: num-. #412

lread opened this issue May 15, 2022 · 0 comments · Fixed by #414

Comments

@lread
Copy link
Collaborator

lread commented May 15, 2022

I noticed this when clj-kondo had trouble understanding what this symbol was.

Clojure docs state:

Symbols beginning or ending with '.' are reserved by Clojure

This technically part of our public API and changing it is a breaking change.
But a grep.app, as of this writing, shows only Etaoin as using num-..

I think it'd be pretty safe to rename, I'm thinking num-dot.

We'll document it as a minor breaking change in the changelog.
lread added a commit to lread/etaoin that referenced this issue May 15, 2022
@lread
Rename etaoin.keys/num-. to etaoin.keys/num-dot +
132b817 
The symbol `num-.` is technically an invalid Clojure symbol and can
confuse tooling.

Minor breaking change, see changelog for impact.

Closes clj-commons#412
lread added a commit to lread/etaoin that referenced this issue May 15, 2022
@lread
Rename etaoin.keys/num-. to etaoin.keys/num-dot +
05ef646 
The symbol `num-.` is technically an invalid Clojure symbol and can
confuse tooling.

Minor breaking change, see changelog for impact.

Closes clj-commons#412
@lread lread mentioned this issue May 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename etaoin.keys/num-. to etaoin.keys/num-dot lread/etaoin
1 participant
@lread