Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reduce reviewers scope #200

Merged
merged 1 commit into from
Aug 19, 2024
Merged

ci: Reduce reviewers scope #200

merged 1 commit into from
Aug 19, 2024

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Aug 1, 2024

What's changed

From a discussion in the product<>engineering retro today. The
tech-devs team is quite broad, and ends up with people receiving a lot
of emails.

The same as climatepolicyradar/navigator-admin-frontend#84.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

@jesse-c jesse-c requested a review from a team as a code owner August 1, 2024 12:37
@jesse-c
Copy link
Contributor Author

jesse-c commented Aug 5, 2024

@olaughter: Could you please add the team again, like you did for the other PR?

@olaughter
Copy link
Contributor

@olaughter: Could you please add the team again, like you did for the other PR?

Done! Sorry for being slow 😅

From a discussion in the product<>engineering retro today. The
tech-devs team is quite broad, and ends up with people receiving a lot
of emails.

The same as climatepolicyradar/navigator-admin-frontend#84.
@jesse-c jesse-c force-pushed the reduce-reviewers-scope branch from 9ba30db to e6fefd6 Compare August 15, 2024 14:08
@jesse-c
Copy link
Contributor Author

jesse-c commented Aug 15, 2024

@katybaulch: I've rebased it, and waiting for CI. I've requested a re-review :)

Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thanks Jesse!!! 🙏🏻 ✨

@katybaulch katybaulch self-requested a review August 19, 2024 11:36
@jesse-c jesse-c merged commit f49f67d into main Aug 19, 2024
18 checks passed
@jesse-c jesse-c deleted the reduce-reviewers-scope branch August 19, 2024 12:36
jesse-c added a commit to climatepolicyradar/navigator-backend that referenced this pull request Aug 27, 2024
jesse-c added a commit to climatepolicyradar/navigator-backend that referenced this pull request Sep 25, 2024
jesse-c added a commit to climatepolicyradar/navigator-backend that referenced this pull request Sep 25, 2024
jesse-c added a commit to climatepolicyradar/navigator-backend that referenced this pull request Sep 25, 2024
jesse-c added a commit to climatepolicyradar/navigator-backend that referenced this pull request Sep 25, 2024
jesse-c added a commit to climatepolicyradar/navigator-backend that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants