Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reduce reviewers scope #84

Merged
merged 1 commit into from
Aug 1, 2024
Merged

ci: Reduce reviewers scope #84

merged 1 commit into from
Aug 1, 2024

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Jul 25, 2024

What's changed

From a discussion in the product<>engineering retro today. The tech-devs team is quite broad, and ends up with people receiving a lot of emails.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

@jesse-c jesse-c requested a review from a team as a code owner July 25, 2024 14:23
@jesse-c jesse-c marked this pull request as draft July 25, 2024 14:25
Copy link

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jesse, this is definitely the sort of thing we want to be doing! We had a conversation just before you joined about renaming our teams into platform and application. I'm not sure whether these new teams have been created in GitHub yet, but we want to change the team responsible in this PR from tech-dev to application rather than the old software team 🙂

@olaughter
Copy link

Hey @katybaulch, they haven't been created yet. From what I remember there was some synchronisation needed on changing the names so we wouldn't break existing workflows. I'm not sure when we'll get time to switch, so would suggest this goes in now so we can start benefiting from it and we revisit when we get to it?

@olaughter
Copy link

I've just added the team to this repo so the codeowenrs file is now valid 😁

@jesse-c
Copy link
Contributor Author

jesse-c commented Aug 1, 2024

@katybaulch: That's good to know! And @olaughter I'm a fan of the progressive approach too, and thank you for adding the team 😉

Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - will need updating to application at some point but for now this is great for reducing reviewer scope :)

From a discussion in the product<>engineering retro today. The
`tech-devs` team is quite broad, and ends up with people receiving a lot
of emails.
@jesse-c jesse-c force-pushed the reduce-reviewers-scope branch from fcf2f99 to 847b8ae Compare August 1, 2024 12:34
@jesse-c jesse-c marked this pull request as ready for review August 1, 2024 12:34
@jesse-c
Copy link
Contributor Author

jesse-c commented Aug 1, 2024

Thank you @katybaulch and @olaughter!

jesse-c added a commit to climatepolicyradar/navigator-frontend that referenced this pull request Aug 1, 2024
From a discussion in the product<>engineering retro today. The
tech-devs team is quite broad, and ends up with people receiving a lot
of emails.

The same as climatepolicyradar/navigator-admin-frontend#84.
@jesse-c jesse-c merged commit 48c3916 into main Aug 1, 2024
9 checks passed
@jesse-c jesse-c deleted the reduce-reviewers-scope branch August 1, 2024 12:38
jesse-c added a commit that referenced this pull request Aug 1, 2024
jesse-c added a commit to climatepolicyradar/navigator-frontend that referenced this pull request Aug 15, 2024
From a discussion in the product<>engineering retro today. The
tech-devs team is quite broad, and ends up with people receiving a lot
of emails.

The same as climatepolicyradar/navigator-admin-frontend#84.
jesse-c added a commit to climatepolicyradar/navigator-frontend that referenced this pull request Aug 19, 2024
From a discussion in the product<>engineering retro today. The
tech-devs team is quite broad, and ends up with people receiving a lot
of emails.

The same as climatepolicyradar/navigator-admin-frontend#84.
jesse-c added a commit to climatepolicyradar/navigator-admin-backend that referenced this pull request Sep 26, 2024
jesse-c added a commit to climatepolicyradar/navigator-admin-backend that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants