-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Reduce reviewers scope #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jesse, this is definitely the sort of thing we want to be doing! We had a conversation just before you joined about renaming our teams into platform and application. I'm not sure whether these new teams have been created in GitHub yet, but we want to change the team responsible in this PR from tech-dev to application rather than the old software team 🙂
Hey @katybaulch, they haven't been created yet. From what I remember there was some synchronisation needed on changing the names so we wouldn't break existing workflows. I'm not sure when we'll get time to switch, so would suggest this goes in now so we can start benefiting from it and we revisit when we get to it? |
I've just added the team to this repo so the codeowenrs file is now valid 😁 |
@katybaulch: That's good to know! And @olaughter I'm a fan of the progressive approach too, and thank you for adding the team 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - will need updating to application
at some point but for now this is great for reducing reviewer scope :)
From a discussion in the product<>engineering retro today. The `tech-devs` team is quite broad, and ends up with people receiving a lot of emails.
fcf2f99
to
847b8ae
Compare
Thank you @katybaulch and @olaughter! |
From a discussion in the product<>engineering retro today. The tech-devs team is quite broad, and ends up with people receiving a lot of emails. The same as climatepolicyradar/navigator-admin-frontend#84.
From a discussion in the product<>engineering retro today. The tech-devs team is quite broad, and ends up with people receiving a lot of emails. The same as climatepolicyradar/navigator-admin-frontend#84.
From a discussion in the product<>engineering retro today. The tech-devs team is quite broad, and ends up with people receiving a lot of emails. The same as climatepolicyradar/navigator-admin-frontend#84.
Similar to climatepolicyradar/navigator-admin-frontend#84, and the others!
Similar to climatepolicyradar/navigator-admin-frontend#84, and the others!
What's changed
From a discussion in the product<>engineering retro today. The
tech-devs
team is quite broad, and ends up with people receiving a lot of emails.Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x