Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set focus on toolbar buttons when they are clicked to unfocus a… #1475

Merged
merged 2 commits into from
Aug 30, 2019
Merged

feat: set focus on toolbar buttons when they are clicked to unfocus a… #1475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15fee26
feat: set focus on toolbar buttons when they are clicked to unfocus a…
fxisco Aug 23, 2019
1a2cdd2
Add new line
fxisco Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/toolbar/edit-toolbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@

<!-- display individual buttons on larger screens (viewport >= 600px) -->
<component
:ref="option.id"
size="large"
v-for="option in activeToolBarOptions"
:color="option.color || 'white'"
Expand Down Expand Up @@ -394,6 +395,7 @@
},
optionAction(option) {
if (option.action) {
this.$refs[action].focus();
option.action(option.id);
}
},
Expand All @@ -405,7 +407,7 @@
const activeNav = savedTab || 'all-pages';

this.$store.dispatch('showNavBackground', true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave an empty line before a return statement to make ir more readable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhh there was an empty space that my linter removed. Thank you man.


return this.$store.dispatch('openDrawer', activeNav);
});
}
Expand Down