feat: set focus on toolbar buttons when they are clicked to unfocus a… #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxisco
requested review from
pedro-rosario,
manuelurenah,
MariaFdezJ and
james-owen
manuelurenah
approved these changes
Aug 23, 2019
| @@ -405,7 +407,6 @@ | |||
| const activeNav = savedTab || 'all-pages'; | |||
|
|
|||
| this.$store.dispatch('showNavBackground', true); | |||
|
|
|||
There was a problem hiding this comment.
Please leave an empty line before a return statement to make ir more readable
There was a problem hiding this comment.
ohhhh there was an empty space that my linter removed. Thank you man.
pedro-rosario
approved these changes
Aug 29, 2019
…ny active input being used
fxisco
force-pushed
the
focus-when-toolbar-button-click
branch
from
a390f5e to
1a2cdd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR helps the toolbar button to gain focus when is clicked. This way any input that is being edited will loose focus and as result will be saved.
Issue: #1474