Log on Failed Publishs from Scheduler

lib/services/schedule.js

@@ -35,7 +35,15 @@ function publishExternally(url) {
   return bluebird.try(function () {
     const published = replaceVersion(url, 'published');
 
-    return rest.putObject(published);
+    return rest.putObject(published)
+      .then(function (res) {
+        if (res && !res.ok) {
+          log('error', 'failed to publish url from schedule', {
+            url
+          });
+        }
+        return res;
+      });
   });
 }
 
@@ -205,6 +213,7 @@ module.exports.stopListening = stopListening;
 module.exports.setScheduleInterval = setScheduleInterval;
 
 // For testing
+module.exports.publishExternally = publishExternally;
 module.exports.setLog = function (fakeLogger) {
   log = fakeLogger;
 };

lib/services/schedule.test.js

@@ -151,6 +151,27 @@ describe(_.startCase(filename), function () {
       sandbox.clock.tick(intervalDelay);
     });
 
+    it('logs if the publish request is not ok', function (done) {
+      const uri = 'http://abce',
+        scheduledItem = {at: intervalDelay - 1, publish: uri},
+        data = {key:'some-key', value: JSON.stringify(scheduledItem)};
+
+      rest.putObject.returns(bluebird.resolve({ok: false}));
+      siteService.sites.returns([{host: 'a', path: '/'}]);
+      db.pipeToPromise.returns(bluebird.resolve(JSON.stringify([data])));
+      db.get.returns(bluebird.resolve(JSON.stringify(scheduledItem)));
+      db.batch.returns(bluebird.resolve());
+
+      lib.setLog(function (logType, msg) {
+        expect(logType).to.equal('error');
+        expect(msg).to.match(/failed to publish/);
+        done();
+      });
+
+      fn();
+      sandbox.clock.tick(intervalDelay);
+    });
+
     it('logs error if failed to parse JSON', function (done) {
       const uri = 'abce/_pages/abcd',
         data = {key:'some-key', value: JSON.stringify({at: intervalDelay - 1, publish: uri}).substring(5)};
@@ -185,4 +206,18 @@ describe(_.startCase(filename), function () {
       sandbox.clock.tick(intervalDelay);
     });
   });
+
+  describe('publishExternally', function () {
+    const fn = lib[this.title];
+
+    it('handles a false-y response from the rest service', function () {
+      const uri = 'http://abce';
+
+      rest.putObject.returns(bluebird.resolve(null));
+      return fn(uri)
+        .then(function (res) {
+          expect(res).to.be.null;
+        });
+    });
+  });
 });