Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log on Failed Publishs from Scheduler #590

Merged
merged 5 commits into from
Aug 16, 2018

Conversation

yuliyv
Copy link

@yuliyv yuliyv commented Aug 15, 2018

The rest service is built on node-fetch which does not throw on 5xx level errors, as a result we should add a chained then and inspect the response and log when individual publishes fail so they can be more easily tracked

@coveralls
Copy link

coveralls commented Aug 15, 2018

Pull Request Test Coverage Report for Build 1951

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1947: 0.0%
Covered Lines: 4239
Relevant Lines: 4239

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants