Change Signal.fromList's tail from errorX to error #2620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the undefined tail of a signal created with
fromList
into anerror
instead oferrorX
, this makes it clear when you're trying use a signal without enough input data.A problem with the
errorX
was that in certain circumstances it can be turned into a signal full of XExceptions. That can turn into a signal full of undefined BitVectors.And when that is used as the basis for the expected values of a
outputVerifierBitVector
you end up with a testbench that reports everything is fine for some (possibly big) part of the test.Also add HasCallStack to Signal.fromList to help with tracing this error.
This currently fails CI because it exposes the exact problem described above in XpmCdcSingle and XpmCdcArraySingle.
I'm working on fixing those tests.
Still TODO: