Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve engine view matcher with new pattern syntax #9694

Merged
merged 28 commits into from
Jun 14, 2021
Merged

Improve engine view matcher with new pattern syntax #9694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3c28b67
Improve engine view matcher with new pattern syntax.
maxbarnas May 13, 2021
5cf44cf
Update the code.
maxbarnas May 13, 2021
39b4ad5
Separate the conditions.
maxbarnas May 13, 2021
089ca6f
Update comments and tests.
maxbarnas May 14, 2021
d18de33
Add missing unit tests for Matcher.
maxbarnas May 17, 2021
c3830f3
Denormalize/extend styles to let them be matched by patterns.
maxbarnas May 17, 2021
86d7084
Make sure all patterns has to be matched to return a match.
maxbarnas May 17, 2021
cafa6cf
Disable temporarily some tests.
maxbarnas May 17, 2021
d2d95d7
Clean up the code for styles expanding.
maxbarnas May 17, 2021
67497d7
Move more logic to normalization function.
maxbarnas May 19, 2021
c7525a2
Update tests.
maxbarnas May 19, 2021
e1944c6
Styles matcher refactor.
niegowski May 20, 2021
be9cead
Add method docs.
maxbarnas May 24, 2021
beb629f
Add tests for `getStyleNames`.
maxbarnas May 24, 2021
1f30627
Adding tests.
maxbarnas May 31, 2021
020950c
Update JSDocs.
maxbarnas May 31, 2021
3918316
Exclude `style` and `class` attributes from `matchAttributes` method.
maxbarnas May 31, 2021
7890348
Add missing comments, revert excluding style and class from matched a…
maxbarnas Jun 4, 2021
dc6a0dd
Fix typo in a comment.
maxbarnas Jun 4, 2021
407afe4
Update docs.
maxbarnas Jun 4, 2021
da2bbb7
Add warning logging to the invalid config pattern.
maxbarnas Jun 8, 2021
8805829
Review fixes.
maxbarnas Jun 10, 2021
b47a065
Adding missing changes.
maxbarnas Jun 10, 2021
98a630e
Renaming missing deep - expand changes.
jacekbogdanski Jun 14, 2021
3cbc8b1
Improved documentation for new matcher options, added missing tests.
jacekbogdanski Jun 14, 2021
0ad4878
Docs minor rewording.
jacekbogdanski Jun 14, 2021
c3249dd
Added info that matcher is matching all or nothing.
jacekbogdanski Jun 14, 2021
ea439f1
Rewording.
jacekbogdanski Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/ckeditor5-engine/src/view/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,11 @@ export default class Element extends Node {
/**
* Returns iterator that contains all style names.
*
* @param {Boolean} [expand=false] Expand shorthand style properties and return all equivalent style representations.
* @returns {Iterable.<String>}
*/
getStyleNames() {
return this._styles.getStyleNames();
getStyleNames( expand = false ) {
return this._styles.getStyleNames( expand );
}

/**
Expand Down
Loading