Improve engine view matcher with new pattern syntax #9694
Conversation
maxbarnas
force-pushed
the
internal/718
branch
3 times, most recently
from
82fedd6 to
b061792
Compare
| // eslint-disable-next-line dot-notation | ||
| if ( isPlainObject( pattern ) && pattern[ 'key' ] && pattern[ 'value' ] ) { | ||
| return pattern; | ||
| } | ||
|
|
||
| // Assume the pattern is either String or RegExp. | ||
| return { key: pattern, value: true }; |
There was a problem hiding this comment.
What if someone provided pattern = { value: 'red' } or pattern = { key: 'color' } ? I'm wondering if we need some handling for that, maybe throw an error if pattern is an object but doesn't include key and value properties?
I'm not sure if checking pattern[property] is enough, as it may have falsy value like pattern = { key: 'data-foo', value: '' }
There was a problem hiding this comment.
It would be also good to have some test coverage for that.
There was a problem hiding this comment.
This seems to not be resolved yet.
| // eslint-disable-next-line dot-notation | ||
| if ( isPlainObject( pattern ) && pattern[ 'key' ] && pattern[ 'value' ] ) { | ||
| return pattern; | ||
| } | ||
|
|
||
| // Assume the pattern is either String or RegExp. | ||
| return { key: pattern, value: true }; |
There was a problem hiding this comment.
This seems to not be resolved yet.
|
Uh, actually I see that a similar test for class names (on |
jacekbogdanski
force-pushed
the
internal/718
branch
from
526d5d7 to
0c9267f
Compare
|
@maxbarnas I've rewritten a bit of documentation for new matcher options. It's more organized now so should be more readable for users. Could you take a look at these changes if everything is ok? 84f971f |
jacekbogdanski
force-pushed
the
internal/718
branch
from
039036f to
ea439f1
Compare
Suggested merge commit message (convention)
Feature (engine): Improved engine view matcher with new pattern syntax allowing to match attribute keys using regular expressions. Unified pattern syntax between attributes, styles, and classes. Closes #9872.
Feature (engine): Added special
expandoption toStylesMap.getStyleNames()and viewElement.getStyleNames()methods allowing to expand shorthand style properties.Additional information
StylesProcessorwill be handled in the follow-up: Add tests toStylesProcessor#9811.styleandclassattributes is reverted back to original form. There is a follow-up, where we'll decide how to approach this: Normalize further patterns passed to Matcher #9813.