Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataController#toView() should have a default value for the options parameter #9295

Merged
merged 3 commits into from
Mar 18, 2021
Merged

DataController#toView() should have a default value for the options parameter #9295

merged 3 commits into from
Mar 18, 2021

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented Mar 18, 2021 •
edited by pomek
Loading

Suggested merge commit message (convention)

Fix (engine): DataController#toView() should have a default value for the options parameter. Closes #9293.

pomek
pomek approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit f77a3d5 into release Mar 18, 2021
@pomek pomek deleted the i/9293 branch March 18, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scofalik @pomek