Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataController#toView() should have default value for options parameter #9293

Closed
scofalik opened this issue Mar 18, 2021 · 1 comment
Closed

DataController#toView() should have default value for options parameter #9293

scofalik opened this issue Mar 18, 2021 · 1 comment
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 41 (v27...

Comments

@scofalik
Copy link
Contributor

scofalik commented Mar 18, 2021 •
edited
Loading

📝 Provide a description of the improvement

Some time ago we started to pass options parameter (available in DataController#get() and #toView() methods. While in get() it received default value ({}), it does not have a default value in toView(). Sometimes we use toView() directly and when doing this we have conversion errors in converters that check conversionApi.options object. One such place is clipboard handling.

Same goes for stringify().
@scofalik scofalik added type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Mar 18, 2021
@scofalik scofalik self-assigned this Mar 18, 2021
@scofalik scofalik added this to the iteration 41 milestone Mar 18, 2021
@scofalik scofalik mentioned this issue Mar 18, 2021
Merged
pomek added a commit that referenced this issue Mar 18, 2021
@pomek
Merge pull request #9295 from ckeditor/i/9293
f77a3d5 
Fix (engine): `DataController#toView()` should have a default value for the `options` parameter. Closes #9293.
@pomek
Copy link
Member

pomek commented Mar 18, 2021

Fixed by f77a3d5.

@pomek pomek closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 41 (v27.0.0)
Development

No branches or pull requests
2 participants
@scofalik @pomek