Ck/epic/2973 document lists #11503
Merged
Ck/epic/2973 document lists #11503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate files for better readability.
…he list of changed blocks.
…pace/delete integration.
…and inline widgets.
# Conflicts: # packages/ckeditor5-code-block/package.json # packages/ckeditor5-engine/src/conversion/downcasthelpers.js # packages/ckeditor5-list/package.json
# Conflicts: # packages/ckeditor5-list/package.json
…tor/ckeditor5 into ck/11198-make-sure-list-isnt-split
…list-item Internal (list): Deleting a widget which is a document list item should be possible. Closes #11346.
…split Feature (engine): Added a new `insertObject()` method to the `Model` for inserting elements defined as objects by schema into a model (see #11198). Feature (engine): Added a new `setAllowedAttributes()` method to the `Schema` that validates attributes if they are allowed on given element before setting them (see #11198). Feature (engine): Added a new `getAttributesWithProperty()` method to the `Schema` that retrieves attributes from a node which have given property (see #11198). Other (media-embed): Added an optional `findOptimalPosition` parameter to `insertMedia()` function that allows for inserting `media` element without breaking content (see #11198). Feature (paragraph): Added an optional `options.attributes` parameter to `InsertParagraph` command that allows setting attributes on created paragraph (see #11198). Internal (list): Document list items should not get split by inserting block objects (widgets). Closes #11198. Internal (engine): The `findOptimalPosition()` helper is now available in the ckeditor5-engine package for internal use (see #11198). Internal (table, page-break, horizontal-line, media-embed, html-embed, image): `table`, `pageBreak`, `horizontalLine`, `media`, `imageBlock`,`imageInline` elements are now inserted with `insertObject()` function instead of `insertContent()` (see #11198).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (list): Introducing the document list editing feature. Closes #10812.
Other (engine): The
isAllowedInsideAttributeElementoption was removed, from now onAttrubuteElementsare allowed to wrap any view element.Fix (link): The link decorators should be converted on the block images only once (should not wrap block image with an additional link).
Other (engine): The
Schemais extended by the new generic type:$container. Container elements can contain$blockor$containerelements.Other (engine): The
DowncastHelpersare passing an additional parameter to the creator functions (thedatathat provides more context to the element creator callback.Other (engine): The
ConversionApiprovided by theUpcastDispatcheris extended with an additional methodkeepEmptyElementthat marks an element that was created during splitting some model element that should not get removed on conversion even if it's empty.Other (engine): The
Differchange entries forinsertandremovetypes are extended with a map of attributes that were set while inserting an element or that were on an element while it got removed.MINOR BREAKING CHANGE (engine): The
isAllowedInsideAttributeElementoption is removed soAttributeElements can wrap any view element (according to positions). Make sure that you are not wrapping anyContainerElementby an accident by not checking the target in the converter. Those would previously get wrapped by anAttributeElementthat immediately would be removed by theContainerElementwithin it so there would not be any visual effect.Feature (list): Introducing the document list properties feature. Closes #11065.
Internal (engine): Added option for the
DomConverterto transparently render only the content of the element in the data pipeline.Additional information
This is an epic PR (switched from the old feature branch #11010).